Sven-Hendrik Haase

Results 490 comments of Sven-Hendrik Haase

Cool, before I do a proper review, could you add a test to check that other directories are now indeed forbidden?

You can take a look at the other tests concerning the upload. It should be somewhat straight forward. Just remember: If you messed up and the test doesn't pick it...

I'd be happy to merge as-is. Please update the `README.md` with the new output of `miniserve --help` and fix the formatting issue and we're good to merge.

Please run `cargo fmt` to fix CI.

There's a small lint to fix there.

I'd be fine if we don't run that test on Windows.

It seems like there's a conflict with the recent QR stuff merge. Could you rebase?

At last! Outstanding work getting it to this state. It took a while but I hope you appreciate that for security stuff we need to go the extra mile. :)

Hm not sure, this might be surprising behavior for users who are used to miniserve just serving the current dir as is. If you did that and had `--upload` active,...

We have something like this now with --readme. Does that work for you?