Sven-Hendrik Haase

Results 490 comments of Sven-Hendrik Haase

Oh, this is very weird. It should definitely support uploading of any type of file since it doesn't really care about the specific type of file. Do you have a...

Anyone wanna take a stab a this?

Are you suggesting it might have been better to just have `POST` always try to upload stuff? It would be simpler for sure but as you are saying, it's not...

Could you add some tests? Since this is going to be deleting things, it needs some proper tests.

> Yeah I'm working on that on and off. The tests are actually written but several are failing. My original intention was to combine the tests and the fixes into...

I think this should probably be behind CLI flags as the performance hit can be severe and we don't want that by default. I will do a proper review a...

Cool stuff! As you already said, a memoization technique would be neat. I think a `HashMap` would be good enough for us. What do you also think about timing out...

> > Cool stuff! As you already said, a memoization technique would be neat. I think a `HashMap` would be good enough for us. [...] > > A `HashMap` would...

Hey, is this still WIP? Would you like to add some tests and rebase and then I can take a proper look at this?

Seems like a good idea. Probably should be an argument to `-p`. Should be easy to implement. Wanna take a stab at this?