Svenn Tveit

I made an attempt here: 45be9b86ed7dd094278c384239993f3816df41c7 which compiled but gave "undefined symbol" errors when I imported any of the "BlackOilSimulator" or "GasWaterSimulator" in Python. It might have something to do...

> > which compiled but gave "undefined symbol" errors > > @svenn-t I think we need to instantiate the templated base class explicitly for the two template values we are...

> Seems like this happens because the derived class PyBlackOilSimulator destructor is called before the base class PyBaseSimulator destructor, and the derived class destructor implicitly frees its Opm::Main pointer which...

> @svenn-t The following seems to work for me: https://github.com/hakonhagland/opm-simulators-1/commit/36ccf4ac8298225f32422b2c3144193eacb0777c Indeed, this worked for me as well. Thanks a lot for the fixes! Unfortunately, I get a lot of "violates...

> @svenn-t Do you have any test cases for the gas water simulator? Then I can also have a look at it Yes, I have a modified SPE1CASE1 file here:...

> I do not get any error when I compile, can you give more details? I see now that I get warnings and not errors. I have the build output...

> @svenn-t Interesting. I do not get any warnings. Here is my build log [build.zip](https://github.com/user-attachments/files/19323675/build.zip). I compiled like this from the terminal When i build with Debug variant, I also...

> @svenn-t Here is an example of a splitting into two separate modules: https://github.com/hakonhagland/opm-simulators-1/commit/1ff143a8cf78a2a4412b4e623ee1f768848280cd. This compiles without ODR violations for me. > To also make the unit tests pass I...

@akva2 Thanks a lot for your comments! The update hopefully fixes all your comments regarding formatting and build targets with the new python simulators. I also marked the PR as...