Stephen McDowell
Stephen McDowell
I suggest you hold tight and watch this repository. I've been working slowly on getting the install logic working, about two months in the works on and off. I will...
Clarification: hang tight as in continue building nanogui as a child project via `add_subdirectory`. What you currently run into is the current install is missing more than just not installing...
Hey @dalerank, Sorry for being generally unresponsive. Been seeing the changes on the switch box super PR. NanoGUI is kind of in a feature freeze right now as we migrate...
Hi @chpatton013 sorry for never responding to this. Here are my thoughts 1. `removeChildHelper(const std::vector::iterator& child_it)` is a little awkward in my opinion. Why is it necessary? Currently there are...
> @svenevs poke @chpatton013 I'm sorry :( I'm re-investigating right now and comparing with the destructor approach by @wardw. I'm inclined to say that the `remove*` approach (this PR) is...
> - Change asserts in removeChild to an early return. I think it's ok to leave the asserts, there's plenty of other `assert` in the framework. > - Get rid...
Cool! The [`Screen` python bindings](https://github.com/wjakob/nanogui/blob/3e0b2c8dae3a52d88d902d1ef65a86258be00c38/python/widget.cpp#L98-L101) need to be updated, you would add `py::arg("maximized") = false` after `"glMinor"` but before the `D(Screen, Screen)`. Please also add documentation for this in the...
```console $ resources/check-style.sh Error: found the following coding style problems: python/nanovg.cpp:124: py::array::forcecast>& image, int flags){ python/nanovg.cpp:125: if(image.ndim() != 3 || image.shape(2) != 4) The command "resources/check-style.sh" exited with 1. ```...
~This is not possible~. The GLFW objects are *merged into NanoGUI*. So it isn't the case that NanoGUI links against GLFW, it "is" GLFW. There's a detailed description of the...
I can implement the following changes triggered by `NANOGUI_INSTALL` if desired. - Eigen - If `NANOGUI_EIGEN_INCLUDE_DIR` is set, use it. - Otherwise `find_package(eigen3 REQUIRED)` - GLFW - If `NANOGUI_GLFW_TARGET` is...