Stefan van den Oord
Stefan van den Oord
That's a good find. So how do we proceed on this? Are you ok with picking it up? Do you need help?
I'm probably not adding a new insight, but I do want to support the "local undo" choice and I hope that it get's implemented soon 😉 Due to Corona I've...
> Thanks. First, can you remove 34a15b6b, as that's not strictly related to the purpose of the PR. Ok. I am curious as to why you wouldn't want this small...
> For example, suppose you use the `wrap-resource` middleware. During development, this will likely draw from the `resources` folder, while during production it may instead pull from an uberjar. The...
> [...] but in production most statically served pages will be resources. You got me thinking with that remark by the way. I am now approaching the point that I'll...
Today I ran into this as well. I had a look at the Ring code, and locally I fixed it, but in a different way. I modified the `wrap-content-type` middleware...
Right, backwards compatibility is indeed important but that way it doesn't fix the issue. I'll try if I can somehow add the header in file and resource middleware like you...
I could also add an option to content-type to retain backward compat, since I feel it is actually a bug... Or maybe "if req uri points to DIRECTORY and response...
Oh wait it probably does, I think you're right. I'll have another go at it. (I misread your comment, the word _extension_ being crucial.)
@weavejester I created the pull request. Please let me know if you want me to change anything.