Stanislav Putrya comments

Results 7 comments of


                                            Stanislav Putrya

Incorrect error message `MasterNotFoundError: No master found for 'pre'` when timeout.

+1 the same problem

Add the ability to add healthcheck definition for containers

@googlebot I signed it!

Add the ability to add healthcheck definition for containers

cc @xingao267 , @alex1545 as you were in the discussion in the original issue

Add the ability to add healthcheck definition for containers

> I don't see a reason why this couldn't be merged. The only concern I have is that we're overloading `healthcheck_test` to do multiple types of tests (`CMD`, `CMD-SHELL`, `NONE`,...

Add the ability to add healthcheck definition for containers

> I think it's cool that you put this together, but I'm a little wary of this as-is for a couple of reasons: > > 1. It's a bit telling...

Add the ability to add healthcheck definition for containers

Ah, you meant about an unmarshaling line to the struct. Yeah. Makes sense. I'm not sure `go-containerregistry` will approve this change though since it looks like they don't need such...

Build problem for Tag v1.28.0. Checksum of quiche-envoy-integration/dd4080fec0b443296c0ed0036e1e776df8813aa7.tar.gz was changed

It's the same with all tags though. Branches were fixed because of https://github.com/envoyproxy/envoy/commit/2ed8986f72dcdfabd9e48df67b3b73ac5914d753. But it makes envoy build n other idempotent. I do believe idempotency is the main goal of...