dape icon indicating copy to clipboard operation
dape copied to clipboard

Feature request: add an option to disable removing breakpoints when killing buffer

Open daanturo opened this issue 1 year ago • 1 comments

Breakpoints being cleared when closing the file is quite surprising to me. If the said option is provided, it would be even better (I think) to enable it by default.

daanturo avatar Aug 05 '24 15:08 daanturo

This is a good idea and totally possible, but as of now breakpoints are overlays which are tied to buffers.

If they would be converted to something other thing in dape--breakpoint-buffer-kill-hook then use some other hook to reinstate the overlays if an file with breakpoint(s) is opened again.

Then all the calls to overlay-{get,set} needs to be replaced preferably with some cl-methods which handles both data types.

I prefer still using overlays for live buffers as we get the fringe/margin integration basically for free.

If anyone is up for it remember to get you FSF assignment!

svaante avatar Aug 18 '24 20:08 svaante

@daanturo I have implemented your requested feature, as it required an refactor on pretty much all code touching breakpoints I am expecting to have introduced a couple of bugs, so it will be a while before I publish a new version to elpa.

But feature is pushed to master.

svaante avatar Oct 06 '24 20:10 svaante

It's now released, there are still some work to be done as dape still opens the buffers on startup which is less then ideal.

svaante avatar Oct 11 '24 17:10 svaante

Thank you very much.

daanturo avatar Oct 11 '24 18:10 daanturo