Sushmitha Ravikumar comments

Repositories
Issues
Comments

Results 23 comments of


                                            Sushmitha Ravikumar

Support Security Group Name

Hi @GnatorX, are you planning to add TTL cache changes in the same PR?

Newer controller-gen doesn't correctly recognize markers. Need upgrade.

Partly addressed in https://github.com/aws/amazon-vpc-resource-controller-k8s/pull/369 go/v4 is the default version now, https://book.kubebuilder.io/plugins/go-v4-plugin Keeping this issue open till be move to v4.

Gracefully handle failures in the controller in case of a configuration error with custom networking

The controller is failing to watch/list ENIConfig due to a misconfiguration in CRD. IMO this validation should be handled in [ENIConfig CRD definition](https://github.com/aws/amazon-vpc-cni-k8s/blob/eb43e54b2f973b98b5e40eb45ba9d4a440a7f15d/charts/aws-vpc-cni/crds/customresourcedefinition.yaml). Also, took a look at the full...