amazon-vpc-resource-controller-k8s
amazon-vpc-resource-controller-k8s copied to clipboard
Support Security Group Name
-
sg name field in crd
-
add implementation
-
Move to getsgforVPC, move SG names into SG, unique items validation
-
Add TTL cache (15 minutes) to Security group name to ID calls to reduce calls to GetSecurityGroupForVPC
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Hi @GnatorX, are you planning to add TTL cache changes in the same PR?
I have added TTL cache. Sorry for the delay.
@sushrk
Hi @GnatorX. Do you have time to follow up on the feedback provided? I'm very excited to see this feature in one of the next releases of AWS VPC CNI, so let me know if I can help picking it up from here.
Ya I can do that. Sorry this is the same person as @GnatorX, sometimes I forget to switch between my accounts
All comments addressed. Just need to know if we are interested in exposing the cache ttl
@haouc Hey, is there someone from AWS side that can pick this back up?
@GnatorX can you maybe add @haouc to the reviewers? and re-request @sushrk
I'd love to make all envs for my deploys look the same instead of the random sg-ids in each different env.
i dont think i have those powers. I know that sushrk is no longer at AWS however we would need someone else to pick this up from their side.