amazon-vpc-resource-controller-k8s icon indicating copy to clipboard operation
amazon-vpc-resource-controller-k8s copied to clipboard

Support Security Group Name

Open GnatorX opened this issue 10 months ago • 9 comments

  • sg name field in crd

  • add implementation

  • Move to getsgforVPC, move SG names into SG, unique items validation

  • Add TTL cache (15 minutes) to Security group name to ID calls to reduce calls to GetSecurityGroupForVPC


Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

GnatorX avatar Apr 18 '24 16:04 GnatorX

Hi @GnatorX, are you planning to add TTL cache changes in the same PR?

sushrk avatar Apr 24 '24 17:04 sushrk

I have added TTL cache. Sorry for the delay.

GnatorX avatar Apr 25 '24 22:04 GnatorX

@sushrk

GnatorX avatar Apr 29 '24 18:04 GnatorX

Hi @GnatorX. Do you have time to follow up on the feedback provided? I'm very excited to see this feature in one of the next releases of AWS VPC CNI, so let me know if I can help picking it up from here.

vgrigoruk avatar Jul 02 '24 14:07 vgrigoruk

Ya I can do that. Sorry this is the same person as @GnatorX, sometimes I forget to switch between my accounts

garvinp-stripe avatar Jul 02 '24 17:07 garvinp-stripe

All comments addressed. Just need to know if we are interested in exposing the cache ttl

GnatorX avatar Jul 02 '24 17:07 GnatorX

@haouc Hey, is there someone from AWS side that can pick this back up?

GnatorX avatar Jul 30 '24 18:07 GnatorX

@GnatorX can you maybe add @haouc to the reviewers? and re-request @sushrk

I'd love to make all envs for my deploys look the same instead of the random sg-ids in each different env.

taer avatar Sep 10 '24 23:09 taer

i dont think i have those powers. I know that sushrk is no longer at AWS however we would need someone else to pick this up from their side.

GnatorX avatar Sep 10 '24 23:09 GnatorX