Sushant Mane

Results 9 comments of Sushant Mane

I'm still working on client side changes to support streaming within a single route. I've figured out structure for it and working on changes

@majisourav99 - this PR has already been approved. Just checking, are you planning to make any additional changes? Or is it no longer needed?

Even for draft PRs, having a clear and descriptive title is helpful.

>Feel free to try this [microbench](https://github.com/felixgv/venice/commit/99444aea2e82dc9941ad337036755a1709e6eaa3) with/without your change... but so far, the thinking is that TokenBucket is not a bottleneck... For low-contention scenarios (few threads), both implementations perform similarly...

> However, the performance gain of CAS over synchronized is not dramatic. Hence, closing this PR!

@mynameborat - When you get a chance, could you please rebase and update the PR to incorporate the latest server-side changes? Thanks!

@WhitneyDeng To move forward with reviewing/merging this PR, it needs to be updated to follow the new pattern (see the create store API). Do you plan to update it?