Sushain Cherivirala
Sushain Cherivirala
This is way too hardcoded and will almost certainly fail depending on how the installation is done.
> Should I find another way/package for finding path for datafiles in python? > https://github.com/apertium/apertium-apy/blob/master/setup.py#L68. There's probably a different pkg_resources or pkgutil method to get a path to a data...
No, this is a bad idea for a number of reasons including that we shouldn't be searching around the user's filesystem (let's be privacy-sensitive).
Did neither pkg_resources not pkgutil have anything useful? I'm relatively certain they will.
Hm, I tried re-running the build to see if it was a transient error but that didn't help. @unhammer, thoughts?
Ah, indeed! It looks like the transient DTD error has not subsisted after the re-build. @share-with-me check out the build output again. Thanks, @unhammer.
This seems like it would result in both `beta.apertium.org` and `apertium.org` having this string. That seems like a bit of a confusing UX?
Ah, my bad. I misread the implementation. In this case, how would `beta.apertium.org` avoid having this string entirely? It uses the same source tree as `apertium.org`.
Maybe you could add a configuration option that enabled or disabled showing this string? @jonorthwash requested this feature so perhaps he has an opinion on whether it matters that we...
> To end all confusions I have added a logic to check the path of the route and conditionally render the string. Rather than casing on the location within the...