SJ

Results 222 comments of SJ

High level, I don't have a good understanding of the originating problem but the changes themselves seem mostly mechanical. I see green checkmarks, so I'm fine with that. The `pushd`...

If it's the same speed or faster, it's a +1 for me. Question: What's the perf like once we get rid of flake entirely?

That's still a decent improvement, but clearly could be a lot more. There is something to also be said about creating sandboxes and whatnot for lint/check-based operations that won't mutate...

> One thing to remember is that some linters are just formatter we run and check if they've modified any files Yeah, case-by-case - take the optimizations where we can,...

From your linked comment, what is the cost of sandboxing X files on a modern computer? In my mind, if the cost to sandbox ever exceeds the cost of running...

Oh yeah, sure. I'm +1 for this change

Sounds like this might be coming sooner: https://github.com/pex-tool/pex/issues/2096#issuecomment-2229513390

I think in the Slack, we talked about this - and the thing we're not doing is materializing the correct files out (today). So, we should just emit all the...

Lol, yes, I agree - but I personally like emitting both, depending on how they get used - and I do also think it should "just work" as much as...

Ran my script to knock out a bunch of PRs. - `codegen` doesn't work on my machine (maybe something about `thrift`? Didn't look into it yet) - I don't have...