Saad Ur Rahman

Results 20 comments of Saad Ur Rahman

Attempt to resolve the merge conflicts with changes from `master` to check what state the PR is in.

Target files are all within the `heron/instance/src/python/network/`. Documentation for [`asyncio`](https://docs.python.org/3/library/asyncio.html). Based on a very quick look at the code removing the `asyncore` will require a complete rewrite of most of...

Hi @nicknezis, I am trying to get acquainted with the code-base and was wondering if this has been resolved yet? I am looking at the following files: [heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesContext.java](https://github.com/apache/incubator-heron/blob/4d9a7de106d6f1f6de6a96f996735c5fc636011b/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesContext.java) [heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesScheduler.java](https://github.com/apache/incubator-heron/blob/4d9a7de106d6f1f6de6a96f996735c5fc636011b/heron/schedulers/src/java/org/apache/heron/scheduler/kubernetes/KubernetesScheduler.java)\ [heron/spi/src/java/org/apache/heron/spi/common/Config.java](https://github.com/apache/incubator-heron/blob/4d9a7de106d6f1f6de6a96f996735c5fc636011b/heron/spi/src/java/org/apache/heron/spi/common/Config.java)...

> I think this is still in draft and the checklist not complete, so not sure if this is approvable yet. Just wanted to make sure it wasn't merged in...

I don't think the changes in #3797 will affect the Protobuf IDLs that I have put together. This PR is blocked until more people can review and confirm the Protobuf...

We could close this PR but it is very close to getting over the bottleneck for the IDL and `header`/`import` generation for the Protobufs. This would mean we can use...

I have verified that the generated C++, Java, and Python source files match the expected extensions. **_C++:_** https://github.com/apache/incubator-heron/blob/8d38e0e501f2862a673cf1aa2b4da6e7c8d58787/tools/rules/genproto.bzl#L123-L124 https://github.com/surahman/Heron-Protobuf/blob/23a47cfab36cbed6fe1ca93ba0a1e5b09420409d/proto/api/BUILD.bazel#L24-L25 **_Java:_** https://github.com/apache/incubator-heron/blob/8d38e0e501f2862a673cf1aa2b4da6e7c8d58787/tools/rules/genproto.bzl#L44-L45 https://github.com/surahman/Heron-Protobuf/blob/23a47cfab36cbed6fe1ca93ba0a1e5b09420409d/proto/api/BUILD.bazel#L41 **_Python:_** https://github.com/apache/incubator-heron/blob/8d38e0e501f2862a673cf1aa2b4da6e7c8d58787/tools/rules/genproto.bzl#L160-L161 https://github.com/surahman/Heron-Protobuf/blob/23a47cfab36cbed6fe1ca93ba0a1e5b09420409d/proto/api/BUILD.bazel#L49 The next step is to...

> 1. Instead of the following config > > ``` > healthcheck: > enabled: %s > interval: 99s > partitions: > - name: default > queues: > - name: root...

I have examined all the functions for metrics generation in the `HealthCheck` and they are all called locally from the `runOnce` routine and the call tree that stems there. Given...

### REST runtime `Config` updates Updating the `Config` object should not represent an issue. [`updateClusterConfig`](https://github.com/apache/yunikorn-core/blob/d81bf72c9fcdf5255816194d0d2ad68d7d3d69a7/pkg/webservice/handlers.go#L434) will generate the parsed updated `Config` into a struct and then reading/updating values is straight...