Anton Paymyshev

Results 13 comments of Anton Paymyshev

I originally thought it was an implementation detail to forbid such urls, but now it appears it is explicitly specified behavior for url parsing: https://github.com/whatwg/url/pull/619 and https://chromium-review.googlesource.com/c/chromium/src/+/3111118 Actually appearance of...

@kdenhartog @darkdh PTAL

> > Also, for a test plan is it possible for us to inspect the prefs on the filesystem? If so some additional potential options for testing this is we...

> Could you check if we have accounts imported from different paths, all of them work fine? Not sure I got this right. I was able to import both of...

Now we have four rows related to domain resolution in brave://settings/extensions ![image](https://user-images.githubusercontent.com/168356/205881634-f92106de-9f41-4ba2-baa4-da2b25268d0b.png) and this issue blocks sec review https://github.com/brave/security/issues/1099#issuecomment-1335733756 Can we choose a new location for them? 1) Move them...

This PR needs S/P review

wallet core looks ok in general, will wait for base PR gets merged

> [@supermassive](https://github.com/supermassive) is there any progress yes! https://github.com/brave/brave-core/pull/29777