Mario Limonciello

Results 679 comments of Mario Limonciello

> > shouldn't you still have two update types? > > Yup, there are two types; `FuIntelNvm` (no header) and `FuIntelNvmFirmware` (the blob we ship as the update with the...

> libfwupdplugin/tests/intel-thunderbolt.bin Can this be generated at the time of tests rather than the binary stored in the tree?

> * _get_device_id() > * _get_flash_size() > * _get_model_id() > * _get_vendor_id() > * _has_pd() > * _is_host() ASMedia may not be documenting their NVM format. IOW even if they...

I think the part you're missing is the reason that I said that we should rename the plugin linux-usb4 or linux-thunderbolt before. We don't care about the specifics of *how*...

> It seems we can do without the intermediate format (and solve things like _is_native() in a nicer way) if we have a `FuFirmware->compare(other)` vfunc. Then each format can decide...

I think you'll need to share the daemon log in verbose mode so we can see what the modem manager plugin is doing. Please with 1.4.4.

`fwupdmgr modify-config VerboseDomains *` and then reproduce and share the journal `journalctl -u fwupd.service -b` https://github.com/fwupd/fwupd/wiki/Getting-involved

Oh, I notice in there: ```│ Update Error: No vendor ID set``` That might be the root of the problem.