Mario Limonciello

Results 679 comments of Mario Limonciello

> @superm1 -- opinion please -- do you think the self tests should work without a working DBus daemon? I think anything dependent on it should be skipped if the...

I think I'd like to see what this is used for before it's added.

I don't think it's going to work like you expect... I think a safer extra GUID would be to use the udev key `MODALIAS`

Do both use the same firmware across architecture? Or there is one firmware for each ?

Right but so the question here is if that is universal. Would you always want touchpad firmware to target multiple machines across architectures? Or would you want to have the...

Presumably this includes the prefix "acpi:". Is that preferred? I think yes

> I wasn't sure. Is that the subsystem or something else? Modaliases are used by the kernel for loading driver automatically. So yes "acpi" prefix means it's acpi subsystem, of...

I tend to think you're right, it's probably better to set a modalias key for all udev devices in fu-udev-device.c.

OK thanks! I tried to land that in the PR directly. Can you make sure I got it right? (i'm mostly worried about the ACPI one ending in a `:`)