Max Stewart comments

Results 6 comments of


                                            Max Stewart

When using com.archinamon.aspectj-ext and includeJar, the type xxx is defined multiple times

This is also happening for me. It seems to be linked to having multiple variants and using `includeJars` - possibly the jars are being included for each variant?

When using com.archinamon.aspectj-ext and includeJar, the type xxx is defined multiple times

Note, after a little more investigation the additional variants aren't the issue. I've opened a PR that includes a failing test showing the issue ☝️ I'm happy to fix this,...

When using com.archinamon.aspectj-ext and includeJar, the type xxx is defined multiple times

I have pinpointed the problem as the addition of copying the include jars that resolves #108 and updated my PR to revert this change and add a test for both...

AGP 7.0.3 compatibility changes

Just to say, this PR has failing tests (4/5 fail). I've resolved 2 and will continue to look at the other 2 as I get some time over the next...

Construct absolute base href using request data.

A little more info on this, Mozilla specify it can be relative (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base) so debatable if it's worth resolving here. You will also introduce an issue if the site is...

At least one signature is invalid.

pfx and p12 are identical, you _should_ be able to just change the extension. The problem here could be the password on the the private key. Did you remove that...