sunsetlover
sunsetlover
The comment on lines 14 and 16 in `OffersAccessControl.sol` is ambiguous about the unit of `totalCFOEarnings` and `totalLostAndFoundBalance` which I believe is in wei.
### Description Every time `.to(address)` is called, it costs around 10,000 gas (see the ethereum yellow paper). If the expired offers that are being removed belonged to the same address,...
### Description Because of overflow errors, a user could accept an offer much lower than they want. It is possible although probably low risk but potentially high impact. ### Scenario...
### Description In `batchRemoveExpired`, at every iteration `totalCFOEarnings` is updated. Each update corresponds to updating a state variable which costs 5000 gas each time. ### Fix In the beginning of...