sunnycarter

Results 9 comments of sunnycarter

Hi there - is there any update on the review for this? What are the next steps please?

Yes I will look into merge conflicts next week if possible. It's been a long time so I think it may take me a while to work through them. Thanks...

@tenthirtyam please can I ask for some guidance on sorting out these merge conflicts? When I wrote this Pull Request, the vmware/govmomi code was included within this terraform-provider-vsphere repo, and...

@tenthirtyam Ryan Johnson, I've made an attempt at dealing with the merge conflicts here, which included creating a Pull Request on govmomi : https://github.com/vmware/govmomi/pull/2957 My question above still stands as...

@tenthirtyam Hi Ryan, Now that the Upstream PR https://github.com/vmware/govmomi/pull/2957 merged what are the next steps to getting this PR merged please? Is there a way you (or I) can request...

Thank you very much for this review. I've resolved all the requested changes apart from the one that was a question, where I've tried to explain my reasoning. I'm handing...

Sorry about that, I've run it now

> > Sorry about that, I've run it now > > Hi @sunnycarter - there still appears to be a conflict on `vsphere/internal/virtualdevice/virtual_machine_network_interface_subresource_test.go`. @tenthirtyam I've merged main in again now...

Fix in https://github.com/oras-project/oras-py/pull/94/files