sun_ comments

Results 20 comments of


                                            sun_

Potentially scary side-effects of decoupling SwiftFFmpeg/CFFmpeg enums

This should be left out when I wrote it. The new way is to avoid exporting the CFFmpeg module's symbol.

Use binaryTarget instead of systemLibrary

@gregcotten

Use binaryTarget instead of systemLibrary

I'm not sure if the SPM supports dynamic libraries. On vacation at the moment, will try it when I get back. :)

Provide example for packaging FFmpeg binaries

Currently, due to the lack of support for binary dependencies in SPM, I have adopted a similar approach to you. Recently, SPM team put forward a proposal for binary dependencies...

Provide example for packaging FFmpeg binaries

I have added support for [SE-0272](https://github.com/apple/swift-evolution/blob/master/proposals/0272-swiftpm-binary-dependencies.md) in https://github.com/sunlubo/SwiftFFmpeg/pull/41#issue-463928497. Can you try and verify it?

Provide example for packaging FFmpeg binaries

static

Provide example for packaging FFmpeg binaries

It works fine on Xcode11E708 with 5.3-DEVELOPMENT-SNAPSHOT-2020-08-05-a toolchain. I will try Xcode12b4 in next few days.

Provide example for packaging FFmpeg binaries

> I think we need to have a LGPL-compliant version for the build script, and to do that I believe we'll need to use dynamic libraries. which build script？

Provide example for packaging FFmpeg binaries

You mean this part？ ``` --enable-gpl ```

Provide example for packaging FFmpeg binaries

The `--enable-gpl` option has been removed.