Sunjay Bhatia

Results 127 comments of Sunjay Bhatia

If you would like to use path rewriting in Contour, take a look at the HTTPProxy resource: https://projectcontour.io/docs/v1.22.1/config/request-rewriting/#path-rewriting

@izturn could you add some commentary on what kinds of additional things you expect users will want to mount into the Envoy pod? I don't know if we've had requests...

could you add a little more detail to the description on why this feature is useful to you? just for context for anyone picking this up and to add some...

you can disable compression if your response content-type is not in this set: https://github.com/projectcontour/contour/blob/602a77f4a735a45bf58b8cc642eaf66392e166c4/internal/envoy/v3/listener.go#L272-L281 see envoy field documentation: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/compressor/v3/compressor.proto#envoy-v3-api-field-extensions-filters-http-compressor-v3-compressor-content-type

WIP for now, just to save it and get some eyes on it to start if anyone is interested

some discussion at the end of this about a "decision tree" or similar about when to use policy attachment etc.: https://www.youtube.com/watch?v=WMns9-_D9o0&list=PL69nYSiGNLP1GgO7k02ipPGZUFpSzGaHH&index=40&ab_channel=Kubernetes In the context of this design around backend app/protocol...

For context, this comment/function is useful: https://github.com/projectcontour/contour/blob/5af0a4263d73bd24bb2dabf163c7c0e39814de4a/internal/xdscache/v3/route.go#L136-L154 also route sorter: https://github.com/projectcontour/contour/blob/5af0a4263d73bd24bb2dabf163c7c0e39814de4a/internal/sorter/sorter.go#L147 route sorter helper for comparing header + query matches: https://github.com/projectcontour/contour/blob/5af0a4263d73bd24bb2dabf163c7c0e39814de4a/internal/sorter/sorter.go#L113 we first sort the header matches within each dag.Route...

in the failing conformance test, we have two route matches that could apply to the request, both with the same path and number of header matches so the first one...

a couple ideas come to mind to fix this: - add an option to dag.Route, used only in routes generated by HTTPRoute processing, to signify we will not sort on...

e.g. just commenting out these lines makes the conformance tests pass: https://github.com/projectcontour/contour/blob/5af0a4263d73bd24bb2dabf163c7c0e39814de4a/internal/sorter/sorter.go#L119-L129