Sunjay Bhatia
Sunjay Bhatia
from build log: ``` CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags '-extldflags "-static" -w -s -X "main.version=v1.30.0-26-gfe6d6ab" -X "k8s.io/kubernetes/pkg/version.gitVersion=v1.30.0-26-gfe6d6ab" -X "k8s.io/component-base/pkg/version.gitVersion=v1.30.0-26-gfe6d6ab"' -o /home/prow/go/src/k8s.io/cloud-provider-vsphere/.build/bin/vsphere-cloud-controller-manager.linux_amd64 cmd/vsphere-cloud-controller-manager/main.go # k8s.io/component-base/metrics/testutil ../../../pkg/mod/k8s.io/[email protected]/metrics/testutil/metrics.go:73:59: undefined: expfmt.FmtText make: ***...
@dependabot rebase
agree with the above comments 👍🏽
lgtm, i guess just gotta get CI to pass 👍🏽
/approve /lgtm
worth adding a similar issue for e.g. an HTTPRoute that has a parent ref that means it should not be reconciled as it references a Gateway not under the implementation's...
e.g. for https://github.com/vmware/load-balancer-and-ingress-services-for-kubernetes this test is a bit problematic without this type of change
> Following up on today's meeting; The current spec explicitly mentions that in order to merge Gateways, the Listeners have to be distinct - > > https://github.com/kubernetes-sigs/gateway-api/blob/45ab52e94fc5aa981ed96d79d6640446f2c8ffe2/apis/v1/gateway_types.go#L72-L81 > > I...
cc @wrowe @davinci26 @nigriMSFT
/cc @skriss