gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Conformance: resources not referencing a `GatwayClass` managed by the implementation should not be reconciled

Open mlavacca opened this issue 2 years ago • 13 comments

What would you like to be added:

This issue is created out of this discussion.

We should add a conformance test that:

  • create a fake GatewayClass (having a fake ControllerName)
  • create a Gateway referencing the GWC above
  • create an HTTPRoute referencing the Gateway above as a parent.
  • the GatewayClass, the Gateway, and the HTTPRoute must not be reconciled by the implementation, and their status must be left untouched.

Why this is needed:

This is needed because we must ensure that for a route to be reconciled, the root of the chain of objects, the GatewayClass, must belong to the implementation.

mlavacca avatar Dec 04 '23 14:12 mlavacca

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 03 '24 15:03 k8s-triage-robot

/remove-lifecycle stale

youngnick avatar Mar 04 '24 23:03 youngnick

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jun 03 '24 00:06 k8s-triage-robot

worth adding a similar issue for e.g. an HTTPRoute that has a parent ref that means it should not be reconciled as it references a Gateway not under the implementation's GatewayClass (or parentrefs are empty etc.)

sunjayBhatia avatar Jun 03 '24 17:06 sunjayBhatia

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Jul 03 '24 18:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-triage-robot avatar Aug 02 '24 18:08 k8s-triage-robot

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 02 '24 18:08 k8s-ci-robot

This is still relevant.

/reopen

mlavacca avatar Aug 05 '24 13:08 mlavacca

@mlavacca: Reopened this issue.

In response to this:

This is still relevant.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Aug 05 '24 13:08 k8s-ci-robot

/triage accepted /remove-lifecycle rotten /assign

mlavacca avatar Aug 13 '24 08:08 mlavacca

I've had a chat with @Devaansh-Kumar and he is willing to pick up this issue. Changing the assignee accordingly.

/unassign /assign @Devaansh-Kumar

mlavacca avatar Oct 24 '24 11:10 mlavacca

@mlavacca: GitHub didn't allow me to assign the following users: Devaansh-Kumar.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

I've had a chat with @Devaansh-Kumar and he is willing to pick up this issue, changing the assignee accordingly.

/unassign /assign @Devaansh-Kumar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Oct 24 '24 11:10 k8s-ci-robot

/assign

Devaansh-Kumar avatar Oct 24 '24 12:10 Devaansh-Kumar

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar Oct 24 '25 12:10 k8s-triage-robot

/triage accepted

youngnick avatar Oct 27 '25 05:10 youngnick