Sunjay Bhatia
Sunjay Bhatia
Thanks for spelling that out, makes sense We have not put too much work into Contour's UX when using an ALB setup so we'll have to think a little about...
This came up as a need from a user at Kubecon just now!
Seems like a reasonable request, changing tags to a feature request. Here is a link to the field that enables this: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/cluster/v3/circuit_breaker.proto#envoy-v3-api-field-config-cluster-v3-circuitbreakers-thresholds-track-remaining
There are a couple places where we configure circuit breaker thresholds: - https://github.com/projectcontour/contour/blob/b865f33cb5f10e082e3cfbc9a0a54bb6c3a3ff18/internal/envoy/v3/cluster.go#L82-L89 - https://github.com/projectcontour/contour/blob/b865f33cb5f10e082e3cfbc9a0a54bb6c3a3ff18/internal/envoy/v3/bootstrap.go#L220-L234 As far as I know, it should be as simple as setting the linked field...
Let me know if you would like to be assigned @Akhil-2001, thanks!
Here's a diff of what the second option above starts to look like: ``` diff --git a/test/e2e/framework.go b/test/e2e/framework.go index 8eb42e0b..dc81705e 100644 --- a/test/e2e/framework.go +++ b/test/e2e/framework.go @@ -200,9 +200,9 @@ func...
yep @satyazzz123 that looks correct 👍🏽 another part of this that would be super helpful would be to start using this helper for any tests that currently create any namespaces...
you can use the `e2e` or `run-e2e` make targets to run the end to end tests: https://github.com/projectcontour/contour/blob/main/Makefile#L321-L324 you will need docker installed in the environment you are running the tests...
> Do the code changes look good? is it correct? Not quite no, we want to basically get rid of the parts of the test setup in the original block...
> I tested this and looks good! > > Couple of comments/questions inline and also, at the top of the guide, there is still reference to the annotations that can...