Sunho Kim

Results 21 comments of Sunho Kim

This is following up of epic bent's https://github.com/Vita3K/Vita3K/issues/417

Nice, why not ready for review?

Maybe worth splitting off pr if you want. I like introducing conan btw -- much better than our fragile DIY boost building.

> > Maybe worth splitting off pr if you want. I like introducing conan btw -- much better than our fragile DIY boost building. > > I initially just wanted...

> If libc++ and lld packages are now required would be nice to add them to the building instructions, same goes for conan if necessary I don't think we should...

@disjukr 커미터 분들도 의견을 낼 수 있게 여기서 얘기하죠.

일단 제가 작업하면서 떠오른 개선안을 나열해볼게요. 1. 아티클, 리포터 타입을 index에서 분리 2. 파서 구현체를 추상 클래스에서 상속받도록 (인터페이스) parse 함수 이름 스팰링같은걸 틀렸을 때 타입 오류로 뜨면 좋을 것...

@stanislas-m Here's the spec requested in #318 - If the association is has-one, eagerly updating the parent model will update the child using fk_id (not considering id of the child...

@mclark4386 1. I think it would be useful to cause an error if the children don't exist in a many-to-many relationship. Because it is usually used to describe the relationship...

Oh I just read the code and finally got what you've been talking about! Then it would be reasonable to save children in many-to-many if it's an eager connection. I...