Ivan Maximov

Results 815 comments of Ivan Maximov

It will be also cool to have such filtering feature to remove boring noise like ```CSharp at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() ``` and many other TPL glue methods,...

Ok. I really did not notice. But other methods can be cited as an example: ```CSharp Task System.Threading.Tasks.TaskHelpersExtensions.CastToObject(Task task) object CallSite.Target(Closure, CallSite, object) TRet System.Dynamic.UpdateDelegates.UpdateAndExecute1(CallSite site, T0 arg0) ```

Package version is not required to be equal to assembly version. These things are completely different. Package is a "stuff-wrapper" with its own versioning. It may contain anything you can...

> Since **most of the time** this happens when deserializing a result list, the ambiguity introduced when serializing **wouldn't a big issue**. What are these assumptions based on?

πŸ‘ I am amazed by people who continue attempts to invest in this project! On the other hand, it's a shame that the work performed with a probability is close...

It is unlikely that this PR will be accepted (like many others). At least I'll be very surprised. The repo is practically dead.

It seems to me that this PR (as many others) is unlikely to be merged. This is new functionality, not a bugfix. The introduction of new functionality assumes its support...

I also encountered this problem.

Hi folks. This is not an issue with `Debug.Assert` at all. The issue is `&&` operator inside it. You can switch `&&` to `&` to get full coverage. Confirmed here...

The same situation here: https://app.codecov.io/gh/graphql-dotnet/parser/blob/master/src/GraphQLParser/LexerContext.cs ![ΠΈΠ·ΠΎΠ±Ρ€Π°ΠΆΠ΅Π½ΠΈΠ΅](https://user-images.githubusercontent.com/21261007/152432250-d68fb4a8-aeb1-491f-aea2-b4275d34425e.png) ![ΠΈΠ·ΠΎΠ±Ρ€Π°ΠΆΠ΅Π½ΠΈΠ΅](https://user-images.githubusercontent.com/21261007/152432292-1f6fff8a-724b-46ff-b89a-1abd10552885.png) ping @Shane32 FYI