debing.sun

`RedisModule_GetClientInfoById` is not thread-safe, clients may be changed in the main thread. Looks like we're still missing some api thread-safety reminders. The example you gave is thread-safe. In fact most...

> Thanks for confirmation. Just to clarify one thing, what is the difference between null vs blocked client as argument while calling RedisModule_GetThreadSafeContext() in this scenario? Passing NULL determines whether...

@samsaha-ms don't require lock, because we assure that these callbacks can be called by only one thread.

@samsaha-ms sorry, i need to retract my reply above. because these callbacks may be called in the main thread or in the module thread, calling these non-thread-safe api also needs...

``` memtier_benchmark-1Mkeys-load-list-rpush-with-10B-values | 163414.0 | 161272 | -1.3% | No Change memtier_benchmark-1Mkeys-load-list-with-100B-values | 151059.0 | 150453 | -0.4% | No Change memtier_benchmark-1Mkeys-load-list-with-10B-values | 166761.0 | 162590 | -2.5% | No...

a simple benchmark ``` memtier_benchmark --test-time 60 -t 15 --hide-histogram --pipeline=50 --command="lpush l a" ``` @skaslev I still think this PR will bring regression. I think we should make some...

@skaslev i use `--save ""`, i'll try again.

@skaslev i can still see the regression of 3.8% ./src/redis-server --save "" memtier_benchmark --test-time 60 -t 15 --hide-histogram --pipeline=50 --command="lpush l a" -x 3 unstable ``` BEST RUN RESULTS ==================================================================================================...

@skaslev not sure why i got improvement(+%3) from this PR through `RPUSH` benchmark. i tries two times and it gives the same result. but i didn't see that the changes...

@skaslev please take a look the issue from copilot ``` src/pubsub.c:479 The variable 'slot' is used but not defined within this scope. Please ensure it is properly assigned or passed...