Daniel Kudwien comments

Results 69 comments of


                                            Daniel Kudwien

Prepare 3.x wp.org release

Note that I reduced the minimum required maintainer approvals for each PR from 2 to 1 – so you can go ahead and merge this whenever you feel ready 👍

Added a wrapper class around \Firebase\JWT\JWT and \Firebase\JWT\Key

Thanks a lot for contributing this change, @MichaelSowah! 🙂 As I'm fairly familiar with the inner workings of the class loader, I'm skeptical about the proposed solution. Let's discuss in...

Fixed unnecessary user account lookup for device listing on user profile page.

@pesseba Any feedback on the suggested changes? Or shall we just apply them and move forward?

Fix incorrect start_date on exported subscriptions

The build errors are not related to this change.

Fix incorrect start_date on exported subscriptions

The change is still correct and necessary.

Do not validate authentication headers if a valid user was determined already.

Hm. You're probably right. However, the change proposed here still makes sense to me. If any other mechanism successfully authenticated a user already, then there is not really a point...

Do not validate authentication headers if a valid user was determined already.

Still looks good to me. We need a second review/approval to move forward. 😉

GitHub Action to automatically publish releases to wordpress.org Subversion

Unfortunately I think that this is obsolete in the meantime as @dominic-ks already added some GitHub Actions to automate the deployment of releases to wordpress.org. I believe it is using...

Refresh token with valid token returns "rest_no_route."

Thanks! 👌 I added that to the Wiki: https://github.com/usefulteam/jwt-auth/wiki#how-does-the-jwt-flow-with-refresh-tokens-work-overall

Refresh token with valid token returns "rest_no_route."

@Tragio When installing from source, you need to install dependencies using Composer. I just documented installation instructions here: https://github.com/usefulteam/jwt-auth/wiki#how-to-install-the-jwt-auth-plugin-development-version-from-github