Daniel Kudwien

Results 69 comments of Daniel Kudwien

@wavedeck Sounds great. :) Would you like to create a PR that contains the necessary changes? Just make sure that your branch of the PR really only contains the minimum...

The problem is that other plugins are also using the JWT library and they are shipping with a different version of it. The proposed solution does not actually resolve the...

Of course. I'm just saying that we want to understand the root cause better before moving forward with a solution. Are you perhaps able to share some simple steps to...

Just stumbled over the package that allows wrapping Composer dependencies into a custom namespace, so leaving this here as a potential option: https://packagist.org/packages/coenjacobs/mozart

Which algorithm are you trying to use? Potential duplicate of https://github.com/usefulteam/jwt-auth/issues/82

Awesome. I'll try to review this tomorrow or early next week. 🙏

Note that we should consider merging the following PRs before this one / before creating the wp.org release: - https://github.com/usefulteam/jwt-auth/pull/112 - https://github.com/usefulteam/jwt-auth/pull/97 - https://github.com/usefulteam/jwt-auth/pull/84 - https://github.com/usefulteam/jwt-auth/pull/78

All mentioned PRs have been merged. 👌 Question: When are we actually updating the changelog? Only when tagging/creating a release? Or should this be done with every PR?

Yeah. Typically people are using the major version as the heading; i.e., "3.x.x". After merging changes, their compatibility decides what the next version number is going to be. This would...

In essence, we should add the following to the changelog in the readme.txt (outside of diff context, so I sadly cannot suggest): ``` = 3.0.2 = - Fix: Do not...