Pete Campbell

Results 4 comments of Pete Campbell

Assignment in ternaries should definitely be avoided if they are assigning to the same variable, eg ``` condition ? self.foo = bar : self.foo = bar2 ``` vs ``` self.foo...

Another solution is to add a new scope that reproduces the original query, eg ``` scope :with_tag, lambda {|tag| joins(:taggings).where(taggings: { tag_id: tag.id }) } ``` and then replace the...

Do you think this new type should be merged into Happymapper? I can make a PR

I've figured out a workaround using `ViewChild` to get the instance of the `EditableComponent` and call `editMode.set(true)` . ``` import { xxx, ViewChild, AfterViewInit } from '@angular/core'; export class XXX......