Sumit

Results 22 comments of Sumit

thanks for fixing travis, I have dropped the commit from the PR.

@GJRTimmer do you have any more reviews?

Could you please point me to the commit that added this functionality? I looked at callback.go and it doesnot have it. Or may be you could help me convert this...

> @sum12 I do have a few comments on your changes. > > 1. Please use `errors.New` over `fmt.Errorf` if there are no format verbs (like `%v`). done > 2....

``` ➜ find mnt | wc -l 19102 # with patch ➜ time ls mnt/* > /dev/null ls --color=tty mnt/* > /dev/null 0.08s user 0.03s system 36% cpu 0.283 total...

okay I will move the second commit to a new PR for now. Thanks for rough sketch, Question: I dont see `recv_request` on `session` I guess you mean `next_request` (which...

@ubnt-intrepid any inputs here please ?

if you dont mind reviewing I would like to try this stab at it ? Is there anything else that I should look at while working on this. BTW thanks...

well you were right about it. I will look for something else.

https://github.com/sum12/libc/commit/93580add0dc2d66213400d9cc5d2ad19f7c2c436 I tried to fix it. but am not sure the fix is complete.