libc icon indicating copy to clipboard operation
libc copied to clipboard

Published 20 hours ago • verified publisher icon rust-lang

AF_INET and AF_INET6 should be of type sa_family_t

Open Yamakaky opened this issue 8 years ago • 5 comments

It's a define in the includes, but used as a sa_family_t. See sockaddr for example.

Yamakaky avatar Dec 12 '16 03:12 Yamakaky

Unfortunately these probably can't change at this point, but we could consider change for the next major version bump of libc.

alexcrichton avatar Dec 12 '16 23:12 alexcrichton

PRs welcome.

gnzlbg avatar May 29 '19 10:05 gnzlbg

https://github.com/sum12/libc/commit/93580add0dc2d66213400d9cc5d2ad19f7c2c436

I tried to fix it. but am not sure the fix is complete.

sum12 avatar Jun 14 '20 11:06 sum12

Should I create a PR ? I would like to contribute.

sum12 avatar Jun 18 '20 12:06 sum12

Breaking release of libc will be released soon, so we can now change type for AF_INET, etc. But I think its type should not be changed, because first argument of socket is c_int. :) There is no perfect solution here. Let's keep everything as is

safinaskar avatar Apr 04 '24 15:04 safinaskar