Kevin Sullivan comments

Repositories
Issues
Comments

Results 2 comments of


                                            Kevin Sullivan

Export module instead of namespace for TS declaration

Yep it's a breaking type-checking change -- although I'd be surprised if anyone's code with `import * as dayjs from dayjs` actually works with the latest emitted ES modules for...

Export module instead of namespace for TS declaration

Hey everyone, to add some more context for this type of change: The TypeScript definitions should reflect the actual JavaScript API. They should be the same; not different. That's what...