suhas
suhas
Verified the fix locally — the s2i linux/amd64 build now completes successfully after adding replace github.com/openshift/source-to-image => github.com/openshift/source-to-image v1.5.1 to go.mod. This resolves the lfstack.push invalid packing runtime crash reported...
> [APPROVALNOTIFIER] This PR is **NOT APPROVED** > > This pull-request has been approved by: _[suhas-developer07](https://github.com/knative/func/pull/3144#)_ **Once this PR has been reviewed and has the lgtm label**, please assign [jrangelramos](https://github.com/jrangelramos)...
@linux-foundation-easycla recheck
Hi @gauron99, thanks for pointing that out! I’ve restored the func-yaml schema and also completed the EasyCLA verification. Please let me know if any other changes are needed.
> please remove the test data from `pkg`. Theres some absoluteLinks and empty credsStore. These are generated via the tests but not removed yet Thanks for the review! I've removed...
ohh shit!! sorry for the previous contribution i thought that full folder needs to delete. in my latest commit i have reclaimed all the files and deleted what extra added...
> Hey @suhas-developer07 just a little suggestion from my side u can use `git rebase main` ... approach instead of merging (`git merge` ) while updating your branch it's a...
> Hey @suhas-developer07 just a small suggestion I guess you have created a pr from `main` it’s not recommended to create a PR directly from your main branch. It’s better...
> Almost there? This needs to have `./hack/update-codegen.sh` run such that the go.mod is cleaned up. Thanks @lkingland! I’ve run ./hack/update-codegen.sh and pushed the updated changes. Please let me know...
The issue was due to an invalid or missing version reference for github.com/openshift/source-to-image. for resolving the issue add this into an go.mod file replace github.com/openshift/source-to-image => github.com/openshift/source-to-image v1.5.1 Verified via...