Tiago Carvalho

Results 113 comments of Tiago Carvalho

There are still a few instances left to change on `v0.34.0`, namely: https://github.com/anoma/namada/blob/v0.34.0/crates/ethereum_bridge/src/protocol/transactions/update.rs#L10-L24

the only thing we cared about from this issue was the ability to configure cometbft block sizes, which was implemented here: https://github.com/anoma/namada/pull/2187

I think this should be handled separately, with a cmdline flag that would conflict with `--hd-path` (e.g. `--no-mnemonic`). dispatching on the presence of `--hd-path` results in a bit of a...

`parse-duration` is only being used in the CLI, but it can't hurt to move away from it EDIT: here's an alternative: https://docs.rs/duration-str/latest/duration_str/ it depends on `winnow` for parsing, which is...

I only tested an independent implementation (https://github.com/heliaxdev/namada-wallet-go) against `namadaw`.

@Kofituo The patch is relatively simple: you need to hook up a condition to `shared/src/ledger/native_vp/ethereum_bridge/bridge_pool_vp.rs`, which is where the Bridge pool VP lives, rejecting transactions if the Ethereum Bridge is...

Deleting a value from storage still writes a diff of the previous value. No data is actually being deleted, at the RocksDB level. Therefore, we can't free up any space...

This might still be relevant, since keys that aren't deleted carry over a diff from the previous block height, which still contains some data. Please confirm this @yito88

Changed the priority because the Ethereum Bridge is not undergoing active development, currently. However, before its launch, this should definitely be implemented, as it could allow garbage collecting old tallies...

if you want to take this on, feel free @nodersteam