Steven
Steven
Closing in favor of #226
@GeoffreyBooth It looks like windows has been failing on main for awhile https://github.com/nodejs/citgm/commits/main Furthermore, I'm not sure if citgm actually runs any tests against the lookup.json file that I modified.
This should fix it: https://github.com/vercel/next.js/pull/60443
@targos Can you try once more now that its fixed?
@targos I added skip win32. Please run once more (Third time's the charm ☘️ )
@targos Looks like pnpm support isn't quite working. Its not selecting the correct version of pnpm https://ci.nodejs.org/job/citgm-smoker-nobuild/nodes=rhel8-x64/1580/testReport/(root)/citgm/next_v14_0_4/ ``` ERR_PNPM_UNSUPPORTED_ENGINE Unsupported environment (bad pnpm and/or Node.js version) Your pnpm version is...
@targos Interesting. Then perhaps `citgm` should utilize corepack. Or at least manually read the [`packageManger`](https://nodejs.org/api/packages.html#packagemanager) field in package.json to select the correct version of the package manger.
@GeoffreyBooth Next.js is a highly visible project that receives many PRs. We lock down the package manager version so that contributors fail fast when they have the wrong pnpm installed...
I can’t seem to find the place where package managers are installed? Can you share the line of code?
Should I add corepack support to citgm? Perhaps right before install here? https://github.com/nodejs/citgm/blob/12e6902b7a90c42edf60a1f4aa0ef9c19efdfddc/lib/package-manager/install.js#L99