Steven

Results 489 comments of Steven

FYI: There is some new development happening in https://github.com/jscherer92/Quark which is supposed to be a similar project to Electrino which was Electron without all the bulk. It might be worth...

Does `Promise` belong in the globals list?

Brotli is available in core since Node 11 https://nodejs.org/docs/latest-v11.x/api/zlib.html

Eventually, we might even get brotli support in Node Core. See https://github.com/nodejs/node/pull/20458

@siddharthkp That's a good point since they specifically said they wanted to use brotli. Maybe the correct thing to do is fail fast and just throw instead of a warning:...

@siddharthkp Ok the build is failing as expected now that there is a throw. How should we fix the tests so that brotli-size is installed? Add to devDependencies?

@eseliger That was my first thought but I don't see a test harness so I'm not sure how to assert that and error was thrown with the current test commands.

I think @siddharthkp still wanted to make a change here. Another related issue worth pursuing is to get brotli support in Node Core. Put a 👍 on this issue: https://github.com/nodejs/node/issues/18964

FYI, brotli support landed in Node core and should be in the next release.

@siddharthkp Let me make sure I understand your proposal. 1. Move `"brotli-size": "0.0.1"` from `dependencies` to `optionalDependencies` 2. Put a try-catch around `require('brotli-size')` and move it inside `case 'brotli':` -...