Stuart Rowe

Results 21 comments of Stuart Rowe

@jan-molak Please correct me if I am wrong, but there appears to be a timing issue with the `features.ShouldDisplayPipelineStage` test. Although I would expect the test to have failed with...

@awittha could you please review this when you have a chance?

> 1. There is not one single correct behavior for `retry(N) { ... }` in every case, so hardcoding a single special case in jenkins-spock will always be wrong for...

How are you retrieving `author`? Looks like calling the `slackUserIdFromEmail` step is causing the pipeline to be serialized out. This is catching non-serializable objects like `hudson.scm.SubversionChangeLogSet`. I would suggest moving...

@p4paul could you please review this when you have a chance?

@p4paul @skumar7322 are either of you available to review this?

@skumar7322 thanks for pointing that out, I had overlooked it somehow. Should be addressed now 🤞.

@skumar7322 there seems to be an issue with `org.jenkinsci.plugins.p4.SimpleTestServer` that is affecting other PRs too.