Dr. Stefan Schimanski

Results 210 comments of Dr. Stefan Schimanski

We need a thorough API review of the kube-proxy component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time...

This is a non-issue. `oneOf` is supported since the beginning of CRD validation afaik and allows to express "at least one of the fields required": ``` properties: a: type: string...

We renamed this to pizza-apiserver. Not sure we missed to replace some strings. Have you tried your docs with pizza-apiserver instead?

For GKE clusters you need this import: https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster-client-configuration/main.go#L32

Another aspect: if the claim cluster is not the Crossplane cluster (via some binding e.g. through Upbound connector, kube-bind or some day in a kcp world), then the MRs are...

@jbw976 this PR is not ready yet. It includes a couple of improvement all in one PR, not all ready. https://github.com/crossplane/crossplane/pull/5437 merged into master already. That one should be backported.

@negz compare https://github.com/crossplane/crossplane/pull/4822 for a quick attempt to see what explodes in CI. Not much actually.

+1, it's time! 🙂

/lgtm /approve Probably needs more approvers.

@alvaroaleman some more linter hints