enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes

Graduate the kube-proxy ComponentConfig

Open luxas opened this issue 6 years ago • 103 comments
trafficstars

  • One-line enhancement description (can be used as a release note): Introduce v1alpha2 kube-proxy component config version
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/784-kube-proxy-component-config
  • Discussion Link: https://github.com/kubernetes/kubernetes/pull/121830
  • Primary contact (assignee): @aroradaman
  • Responsible SIGs: sig-network
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.32
    • Beta release target (x.y):
    • Stable release target (x.y):
  • [ ] Alpha
    • [x] KEP (k/enhancements) update PR(s): #4311, #4337, #4732, #4886
    • [ ] Code (k/k) update PR(s):
      • [x] 1.31 https://github.com/kubernetes/kubernetes/pull/126072
      • [x] 1.31 https://github.com/kubernetes/kubernetes/pull/126293
      • [x] 1.32 https://github.com/kubernetes/kubernetes/pull/126889
      • [ ] https://github.com/kubernetes/kubernetes/pull/127930
      • [ ] https://github.com/kubernetes/kubernetes/pull/126258
    • [ ] Docs (k/website) update PR(s): https://github.com/kubernetes/website/pull/47001

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

luxas avatar Jan 30 '19 16:01 luxas

We need a thorough API review of the kube-proxy component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time frame feels like rushing in the light of us having just started with component-base.

sttts avatar Jan 31 '19 09:01 sttts

@luxas I don't see a KEP for this issue links in the description. I'm removing it from the 1.14 milestone - to have it added back please file an exception request.

claurence avatar Feb 05 '19 06:02 claurence

I am giving this a try. /assign

rosti avatar Mar 19 '19 10:03 rosti

@luxas @rosti I'm the enhancement lead for 1.15. I don't see a KEP filed for this enhancement and per the guidelines, all enhancements will require one. Please let me know if this issue will have any work involved for this release cycle and update the original post reflect it. Thanks!

kacole2 avatar Apr 11 '19 21:04 kacole2

@kacole2 I am a bit skeptical for a KEP in this release cycle, however if we manage to put something before enhancements freeze for 1.15 then we'll ping you.

rosti avatar Apr 16 '19 10:04 rosti

Initial proposal doc. This is shared with WG Component Standard, SIG Network, SIG Windows, SIG API Machinery and SIG Cluster Lifecycle. If someone has trouble accessing it, ping me.

rosti avatar Jun 05 '19 13:06 rosti

@rosti thanks for picking this up! The common vs. local and per-platform config problems have needed someone who can really focus on them for a while, and I haven't been able to dedicate enough time lately. So I'm grateful someone's looking at this :). This is critical to the future of the componentconfig effort.

mtaufen avatar Jun 05 '19 22:06 mtaufen

I left some comments on your doc.

mtaufen avatar Jun 05 '19 22:06 mtaufen

@vllry, I heard you're also going to be working on kube-proxy componentconfig, wanted to make sure you see this.

mtaufen avatar Jun 06 '19 18:06 mtaufen

@rosti, shall we tag this /w 1.16 and update KEP #1104?

stealthybox avatar Jun 25 '19 15:06 stealthybox

Moving this to the 1.16 milestone to tackle during the next release /milestone v1.16

alejandrox1 avatar Jun 26 '19 14:06 alejandrox1

IMO we should have k/enhancements issues that track full graduation of APIs. from alpha->GA instead of separate ones for beta or GA.

neolit123 avatar Jun 26 '19 14:06 neolit123

If the KEP merges we can have an alpha version released before the end of the cycle, so I think, that it's appropriate to have it in 1.16.

rosti avatar Jul 01 '19 08:07 rosti

Hey there @luxas, I'm one of the 1.16 Enhancement Shadows. Looks like you're on track for v1.16 :)

As a general reminder, the KEP must be merged and in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

mrbobbytables avatar Jul 10 '19 14:07 mrbobbytables

Hi @luxas this is a reminder that the KEP needs to be merged by EOD tomorrow or it will be removed from the 1.16 milestone. Thanks.

kacole2 avatar Jul 29 '19 17:07 kacole2

@luxas @rosti

Enhancement Freeze has passed for 1.16. The KEP at #1104 was never merged and now this is being removed from the 1.16 milestone. If this would like to be re-added, please file an exception and it will require approval from the release lead.

/milestone clear

kacole2 avatar Jul 31 '19 14:07 kacole2

Hello @luxas @rosti, 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see **if this enhancement will be graduating to alpha/beta/stable in 1.17?

** Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

  • The current release schedule is

    • Monday, September 23 - Release Cycle Begins
    • Tuesday, October 15, EOD PST - Enhancements Freeze
    • Thursday, November 14, EOD PST - Code Freeze
    • Tuesday, November 19 - Docs must be completed and reviewed
    • Monday, December 9 - Kubernetes 1.17.0 Released

  • A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release

    • PR is merged in
    • In an implementable state
    • Include test plan and graduation criteria

  • All relevant k/k PRs should be listed in this issue

annajung avatar Oct 02 '19 02:10 annajung

Hi @annajung, The KEP PR is merged, it's in an implementable state and probably the first code PRs will start flowing in either next week or the week after that. So I think, that for now we are on a good track here.

rosti avatar Oct 04 '19 08:10 rosti

Hey @rosti , Thanks for the update! I will add this enhancement to the tracking sheet to be tracked 👍

/milestone v1.17 /stage beta /tracked yes

annajung avatar Oct 04 '19 13:10 annajung

Hey @rosti , Could you please post links to the tests in testgrid and keep track of any tests added for this enhancement?

Thank you!

annajung avatar Oct 07 '19 23:10 annajung

Hello @rosti, I'm one of the v1.17 docs shadows. Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

pgburt avatar Oct 22 '19 15:10 pgburt

Hello @luxas @rosti. I see the docs for this enhancement is set to "Unknown" in the Enhancement Tracker sheet. Do we need to do any work to determine if this requires a placeholder PR for docs?

As a reminder, we're hoping to have placeholder PRs against kubernetes/website (branch dev-1.17) by Friday, Nov 8th. Thanks,

pgburt avatar Nov 02 '19 21:11 pgburt

Hey @rosti 1.17 Enhancement Shadow here! 👋 I am reaching out to check in with you to see how this enhancement is going.

The Enhancement team needs to keep track of k/k PRs related to this enhancement in the tracking sheet. Could you please list out the k/k PRs that are in flight for this so we can track them?

Also, another friendly reminder that we're quickly approaching code freeze (Nov. 14th).

annajung avatar Nov 06 '19 05:11 annajung

Hi @annajung and @pgburt, unfortunately this feature won't make it in time for 1.17. No PRs have been merged or are targeted for a merge before CF, so I would bet, that you want to untrack it for this release.

rosti avatar Nov 06 '19 09:11 rosti

Thank you for the update @rosti. The Enhacement team have moved this from the tracking sheet

/milestone clear /tracked no

annajung avatar Nov 07 '19 05:11 annajung

Hey there @rosti -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18?

The current release schedule is:

  • Monday, January 6th - Release Cycle Begins
  • Tuesday, January 28th EOD PST - Enhancements Freeze
  • Thursday, March 5th, EOD PST - Code Freeze
  • Monday, March 16th - Docs must be completed and reviewed
  • Tuesday, March 24th - Kubernetes 1.18.0 Released

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements

Thanks! :)

palnabarun avatar Jan 13 '20 07:01 palnabarun

@rosti Just a friendly reminder, we are just 7 days away from the Enhancement Freeze (Tuesday, January 28th).

palnabarun avatar Jan 22 '20 09:01 palnabarun

@rosti Just a friendly reminder, we are just 2 days away from the Enhancement Freeze (3 PM Pacific Time, Tuesday, January 28th).

palnabarun avatar Jan 26 '20 20:01 palnabarun

@palnabarun sorry for the late response. This won't be making it in 1.18. Hence you can safely untrack it.

rosti avatar Jan 27 '20 10:01 rosti

@rosti Thank you for the updates. I will update the tracking sheet accordingly.

palnabarun avatar Jan 27 '20 10:01 palnabarun