Santos Gallegos

Results 342 comments of Santos Gallegos

+1 on making that configurable, that would solve the problem from https://github.com/readthedocs/readthedocs.org/issues/8015#issuecomment-800650527 There is a todo there https://github.com/readthedocs/readthedocs.org/blob/b523a780f5c6c97508cfa8a6fac180b03de52418/readthedocs/builds/tasks.py#L324-L326 I haven't thought about the implementation

I think this comes from here https://github.com/readthedocs/readthedocs.org/blob/135025f2a40ad7dfbaabda1261ee048a84e44a72/readthedocs/core/static-src/core/js/doc-embed/sphinx.js#L39-L52 That calls .enable from https://github.com/readthedocs/sphinx_rtd_theme/blob/71d6d182cfeb7872c2399eac4a47d2f3c6b2c7d1/src/theme.js#L18

@ericholscher from my comment https://github.com/readthedocs/readthedocs.org/issues/8497#issuecomment-920437964, that code is exported from our theme, so not sure if we can scope it without breaking our theme. I think we shouldn't export that...

> should this issue be closed and tracked directly in https://github.com/readthedocs/sphinx_rtd_theme/issues/1239 instead? This problem needs to be fixed in both sides. We are calling code from the theme from our...

> I'd love to see an update of this document that really focuses on a unified search experience @ericholscher do you have a preference on https://github.com/readthedocs/readthedocs.org/pull/9533#discussion_r955279645?

@CoderMaggie hi, looks like you don't have the latest version enabled, you can do this from https://readthedocs.org/dashboard/sylius/version/latest/edit/.

Another use case is for users that have versions not compatible with pep 440, instead of renaming all of their versions, they can just rename the slug on rtd and...

I have updated this PR with some of comments from the review from https://github.com/readthedocs/readthedocs.org/pull/9425. There are a couple I didn't address, since I'm -0. But we can continue discussing if...

> How did we ended up into _append_conda_requirements if the build is not a Conda build? It's a conda build https://code.usgs.gov/wma/nhgf/toolsteam/gdptools/-/blob/aae8a912213b856a903ee566ccafa5b3b503ccba/.readthedocs.yml#L9-10

Also, we have this option exposed in the UI ![Screenshot 2021-11-09 at 12-15-35 Edit Advanced Project Settings Read the Docs](https://user-images.githubusercontent.com/4975310/140972393-1bc91e62-108d-4452-b733-0046bd5ad2f1.png)