Dirk Stolle
Dirk Stolle
@ljharb: > LGTM Good. Since this pull request has been approved one and a half month ago but it has not been merged yet: Is there anything else to do?...
@goto-bus-stop or who is currently maintaining browserify: Is there a chance to get a review on the changes? Is this still relevant after almost a year now?
@tafia: No activity here for more than two months. Did you just miss this PR or is something wrong with it? Please let me know whether something prevents the merge...
Hey @tafia, I'm pinging you here as a friendly reminder, because it seems like you forgot about that PR. It's been almost four months now, so I would really appreciate...
Rebased against current master branch to fix merge conflicts.
> I probably am not going to review this. My projects get more PRs per month than can be reviewed, so I focus on the most impactful ones, [...] That...
Encountered the same issue in [one of my projects](https://github.com/striezel/corona/runs/7745203566?check_suite_focus=true). Considering that serde 1.0.142 still worked with rustc 1.48 and seeing that serde 1.0.143 does not, let's take a look at...
> I followed up with @dtolnay on twitter DM about this, and his response was that there is no MSRV policy for serde, and thus this is an issue that...
> This has been fixed in 1.0.144: https://docs.rs/crate/serde/1.0.144/source/Cargo.toml Very good. :) > I'm still _very_ confused as to the MSRV for serde. Should we be looking to rip serde out...
@tafia I just rebased this against the current master branch. Any feedback on this pull request would be appreciated.