Optimize few string allocations
Few string allocating optimizations and replacing of deprecated trim_left_matches.
This ready to review, i guess ;-)
One month ping, @dtolnay.
I probably am not going to review this. My projects get more PRs per month than can be reviewed, so I focus on the most impactful ones, [...]
That is completely understandable. Focus is important when time is a very limited resource.
Maybe one of your co-maintainers can afford the time to review this? I'd rather see pull requests reviewed late than not reviewed at all, because otherwise one may miss potential improvements, even if they are small.
@klensy:
Allocators are fast and nothing here is a bottleneck part of the macro. That puts it right to the bottom for impactfulness unless there is some benchmark data to back it up.
Did you run any benchmarks before and after the changes of this PR? If so, you could provide the data and then maybe it's easier for the maintainer(s) to make a decision on the possible impact of this PR.