Steven Tricanowicz

Results 12 comments of Steven Tricanowicz

I think this is the case for all layer components? I just hit this with `GeoJsonLayer` as well. Is that correct? Would it be reasonable to get react-specific extended typings...

Verified in 4.8.0, I'll try again with 4.9.0

Hmmm, it does seem to be broken in 4.9.0 now and I'm not sure why. My first theory was that we needed to add the `Partial` to the DeckGL object...

Here's the error I'm getting: ``` Type 'Provider' is not assignable to type 'Provider'. Types of property 'propTypes' are incompatible. Type 'WeakValidationMap | undefined' is not assignable to type 'WeakValidationMap...

Good news - This seems to no longer be an issue in 4.9.2.

So I came up with two possible solutions: - The [simple fix](https://github.com/strican/deckgl-typings/tree/geojson-simple), which just adds an extra type to the `data` attribute that's fully generic. This has the smallest delta...

@danmarshall Should I just open a PR? I wanted to get some thoughts before I did so since there were two options.

Alright, @danmarshall I opened up #186 with the simple fix. I'm not sure how we go about validating this. Taking a look at the unit test, we're doing the following:...

Although I guess this was never guaranteed before either. It could have been a string or a Promise. What were you thinking for validating this?

Just to comment, it looks like the issue is that the app is only System DPI aware rather than Per-Monitor DPI aware. Here's some [more details](https://msdn.microsoft.com/library/windows/desktop/mt843498(v=vs.85).aspx(d=robot)). It also appears that...