Sean Treadway

Results 36 comments of Sean Treadway

I think that's a good plan. I simply don't have the time to accept patches and tests for this project, and bringing under the RabbitMQ codebases makes sense. On Fri,...

This is great. To bikeshed the names a bit, I think the existing names like `QosContext` etc make sense because they follow the standard library adoption of context aware IO...

> I meant: In order to deal with canceled RPC calls. Should we close the channel? or keep it open? My first reaction is to keep the channel open. AMQP...

When looking at error values, can you suggest a way of promoting a client side context.Context.Err() into an *amqp.Error?

> Note that sharing a channel for concurrent publishing, for example, is inherently unsafe because a published messages is 2 or 3 frames on the wire and you can end...

> * Context support in this case would really achieve the goals it might in other libraries The primary use case for the context package is to represent a distributed,...

AMQP requires TCP which offers transport reliability. The heartbeater will close the connection on read timeout, which will return an error should we experience any message loss. I've found RabbitMQ...

> I admire the amount of effort you've put into the docs and perhaps 50 to 65% of the docs can be retained. Unfortunately the docs are not always correct...

I think it's finally time to add some interfaces because it's a frequent enough request to reduce the typing needed to properly write testable producers/consumers. [wabbit](https://github.com/NeowayLabs/wabbit) does a pretty good...

Adding interfaces is a backwards compatible change, so #312 doesn't yet apply.