Ben Strauss

Results 5 comments of Ben Strauss

We also have the wizard for generating configs... I wouldn't have a problem with what you're proposing, but would be easier to just remove :) and less duplication.

Addressed @jefchien 's comment and alphabetized/refactored a bit. Workflow run in my fork: https://github.com/straussb/amazon-cloudwatch-agent/actions/runs/8651141047/job/23721186276 Generated PR: https://github.com/straussb/amazon-cloudwatch-agent/pull/2/

Run: https://github.com/straussb/amazon-cloudwatch-agent/actions/runs/8651656453/job/23722804958 PR: https://github.com/straussb/amazon-cloudwatch-agent/pull/4

That's because this test case is still commented: https://github.com/aws-observability/aws-otel-test-framework/blob/terraform/validator/src/main/resources/expected-data-template/container-insight/eks/prometheus/nginx_metrics.mustache#L46 Please leave the issue open until the test is uncommented and passing.