stratospher

ACK d82eafb173d6bfa98a59e86a845013cc8528b65d.

happened here too: https://cirrus-ci.com/task/4577902440742912?logs=ci#L2654

> Hmm, "test each commit fails" The problem is that commit https://github.com/bitcoin/bitcoin/commit/606f4f32014f029a6999d7f94b7231fefafdf55f (which switches P2PConnection to v2 by default) is enabled last. It might be best to squash everything into...

@sr-gi, i tried [this manually sending idea](https://github.com/bitcoin/bitcoin/pull/29352#pullrequestreview-1854149947) but i still think intermittent failures are possible there. - we can't get rid of `can_data_be_received` variable because if we don't use this...

> I've been playing around sending anything different than the first 4 bytes as the network magic and test fail on my end (which is expected given data_received is called...

> The one thing I'm a bit unsure about is that this duplicates quite a lot of code, especially in complete_handshake - the main implementation in v2_p2p.py and the overwritten...

> I think it'd be better to have multiple classes that build from v2_p2p and modify what's needed, even if the file gets larger. that's a great suggestion @sr-gi! it's...

I've updated the PR to have different child class implementations for `EncryptedP2PState` based on the disconnection scenario we're testing - `EarlyKeyResponseState`, `ExcessGarbageState` etc... Also introduced 2 more commits for cleaner...

thank you for the helpful reviews @sr-gi! I've updated the PR: - `EARLY_KEY_RESPONSE` test doesn't have `magic_sent` now and the `initial_v2_handshake()` function is cleaner - `EARLY_KEY_RESPONSE` test does sending of...

oh interesting! there's some discussion in https://github.com/bitcoin/bitcoin/pull/29809 about how to update the comments for DNS seed filtering. also cc @naiyoma