stratospher
stratospher
this would be useful to have in #29122. are you planning to address the reviews and undraft the PR?
looks like [this `wait_until`](https://github.com/bitcoin/bitcoin/blob/61de64df6790077857faba84796bb874b59c5d15/test/functional/p2p_compactblocks.py#L390) got forgotten. maybe update that to use `wait_for_getheaders` here too?
converting this PR into a draft. I'll push the updated version which includes the new spec changes in BIP 324 soon.
I've updated the PR to reflect the new spec changes in the BIP. It's built on top of #24545's 78c3ccc. Only the last 19 commits belong to this PR. UPDATE:...
Rebased on #28331. 2 things which affected the tests when rebasing were: 1. `TestNode` can send garbage now 2. since v1 reconnections are now attempted in a queue instead of...
Rebased on master.
Updated since #28374 is merged.
@theStack, @mzumsande thank you for the reviews! I've rebased and addressed your comments. > It seems like the newly introduced functional test p2p_v2_encrypted.py could be merged with the already existing...
> I've noticed that the test p2p_v2_encrypted.py fails if the node under test sends a small amount of garbage (in the range of 0-19 bytes). thanks for catching that @theStack!...
> https://api.cirrus-ci.com/v1/task/6171895557521408/logs/ci.log i wasn't able to reproduce this error - tried it locally on the docker container, setting randomseed and running it in loop. also confused how it could have...