stratospher

Updated the elligator squared encoding function signature from `ellsq_encode(pubkey)` to `ellsq_encode(pubkey, randombytes)` in order to test the BIP 324 test vectors in python.

* updates include: * elligator swift instead of elligator squared * built on top of #26222 * references - https://github.com/bitcoin-core/secp256k1/pull/1129, https://github.com/sipa/bitcoin/tree/202209_ellswift_py * for #24748, we'd want to keep the entropy...

@theStack I've updated the PR to include your suggestion. Documenting it like this might also help people who haven't gone through the algo notice this behaviour in the tests.

Rebased on master, updated to address [review comment](https://github.com/bitcoin/bitcoin/pull/24005#discussion_r1239096530) and to just use commits from 26222 which this depends on.

Thanks @sipa, @theStack! I've updated to include ellswift test vectors from BIP 324 + addressed review comments.

thanks @maflcko, @0xb10c, @brunoerg. I've updated the PR to address your comments. Open to more thoughts/suggestions in https://github.com/bitcoin/bitcoin/pull/29007#discussion_r1417082950.

thanks for the thoughtful feedback @amitiuttarwar, @0xB10C! I've updated the PR to address your comments. Main changes were: ([git diff](https://github.com/bitcoin/bitcoin/compare/d3c24183483e43dd38209dbaf3c4ac725e13d4a3..1b49149b3ed7366141f0090692256e82032cb9af)) 1. adding an option to restart the node with an...

Updated the PR to remove `-addrmantest` ([git diff](https://github.com/bitcoin/bitcoin/compare/1b49149b3ed7366141f0090692256e82032cb9af..291a1a325db74ca5cd8ae1ca1e488ec62f99bc93)) in 5d27993.

tested ACK 98570fe.

Concept ACK. it's nice to clearly define success/failure paths for `addpeeraddress`. hopefully after #29007, these rare collisions won't happen since a fixed `nKey` can be used.