stratospher

> But it seems confusing to fail with a stack trace / uncaught exception in this case ("Fatal error: protocol.data_received() call failed.") when this is actually expected to happen. is...

thanks @mzumsande for the really great feedback! I’ve rebased on master since #28805 is merged and updated the PR to address your comments.

thanks @theStack, @mzumsande! I've updated the PR to address your comments. Also made this change to `MSGTYPE_TO_SHORTID` construction because of `lint-python.py` failure in the CI ```diff diff --git a/test/functional/test_framework/v2_p2p.py b/test/functional/test_framework/v2_p2p.py...

thanks for the reviews @mzumsande, @sipa, @theStack! i've updated the PR to address your comments. sorry for the delay since i was away.

> There are many more tests possible, right? E.g. sending more than 4095 bytes of garbage. I assume the goal here wasn't to cover everything? yes! goal here was to...

hmm weird, looking into it. i also have a [WIP branch](https://github.com/stratospher/bitcoin/commits/more-v2-tests/) which uses this test file and adds more v2 tests for sending excess garbage bytes, wrong garbage terminator, incorrect...

Thanks for your really nice review @sipa! I’ve addressed your comments. Ready for further review.

Thanks again @sipa! I’ve addressed your comments. Ready for further review.

Thanks again @sipa! I’ve addressed your comments. Ready for further review.

Made some changes to simplify the Elligator squared interface - interact with pubkeys instead of group elements. (added `get_group_element()` and `set_from_curve_point()` in ECPubkey for this purpose) - rename `encode_bytes()` to...